Index node.id in elasticsearch/node metricset #9209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
changed the title
ycombinator
added
review
Metricbeat
ycombinator
commented
Nov 22, 2018
| @@ -1,15 +1,16 @@ | |||
| { | |||
| "@timestamp": "2017-10-12T08:05:34.853Z", | |||
| "beat": { | |||
| "agent": { | |||
There was a problem hiding this comment.
Note to self: Remember that this needs to be beat in the 6.x backport PR.
|
jenkins, test this |
ruflin
approved these changes
Nov 22, 2018
| @@ -93,8 +93,7 @@ func eventsMapping(r mb.ReporterV2, info elasticsearch.Info, content []byte) err | |||
| continue | |||
| } | |||
|
|
|||
| // Write name here as full name only available as key | |||
| event.MetricSetFields["name"] = name | |||
| event.MetricSetFields["id"] = id | |||
There was a problem hiding this comment.
Yeah, it was. We were actually assigning the node ID to the name field in the event. It's easy to get them confused because by default ES will set the node name as the node ID.
There was a problem hiding this comment.
this is potentially a breaking change or a bug fix, so we should probably mention it in the changelog.
There was a problem hiding this comment.
Good point. Added CHANGELOG entry in breaking changes section in d3750ad7e.
|
jenkins, test this |
ruflin
approved these changes
Nov 22, 2018
|
jenkins, test this |
3 similar comments
|
jenkins, test this |
|
jenkins, test this |
|
jenkins, test this |
ycombinator
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR teaches the
elasticsearch/nodemetricset to index the Elasticsearch node's id as the metricset-levelidfield.This is the final PR in a series of recent PRs that ensured that all
elasticsearchmetricsets had module-levelcluster.idandcluster.namefields and that thenodeandnode_statsmetricsets also had thenode.idandnode.namefields.As such, this final PR also adds a CHANGELOG entry.